fix(cli): only publish if changes detected since last release #32433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The changes in this commit focus on the CI workflow for publishing the CLI. The main changes are: 1. The publish job now checks if there are any changes between the last release tag and the new version being published. This is done by using the `git diff` command to compare the changes in the `client/go` directory. 2. If no changes are detected, the workflow will skip the publish step. This ensures that the CLI is only published when there are actual changes, preventing unnecessary releases. 3. The workflow also handles the case where a dev version (starting with "0.0.0-dev") is being used, in which case the changes check is skipped.
freva
previously approved these changes
Sep 19, 2024
…iff checks The changes in this commit address the following: 1. Checkout the repository at the tagged version to ensure the correct code is used for the release. 2. Bypass the diff checks when publishing to GitHub and Homebrew, as these checks are already performed in the "prepare" job.
esolitos
force-pushed
the
publish-cli-publish-only-if-changes-detected
branch
from
19e6f9a to
e9d02c8
Compare
freva
previously approved these changes
Sep 20, 2024
This change updates the GitHub Actions workflow to publish the Vespa CLI to both GitHub Releases and Homebrew. The key changes are: - Publish the GitHub release and capture the release URL - Only publish to Homebrew if a GitHub release was successful - Install the CLI package via Homebrew if a release was published
esolitos
force-pushed
the
publish-cli-publish-only-if-changes-detected
branch
2 times, most recently
from
55024c2 to
dc4205f
Compare
freva
approved these changes
Sep 20, 2024
This was referenced Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Changes on the "Publish Vespa CLI" Github workflow:
git diffcommand to compare the changes in theclient/godirectory.Why
This ensures that the CLI is only published when there are actual changes, preventing unnecessary releases.
A further reason is that we had 2 separate systems checking for changes, one for the Github Releases and another one for Homebrew, this leads to inconsistencies, so this PR merges the validation into an initial check.
Additional info