Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Language server publish github action #32324

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

theodorklauritzen
Copy link
Member

Include the compiled typescript code to the extension. Then the github action will not throw an error while publishing.

Copy link
Member

@bratseth bratseth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't "out" a directory for generated artefacts, which should therefore be ignored?

@theodorklauritzen
Copy link
Member Author

It should be ignored by git, but not by .vscodeignore. If the out folder is ignored in this file, the generated artefacts will not be included in the extension. And then the extension will not have any source code.

@bratseth
Copy link
Member

bratseth commented Sep 3, 2024

Got it.

@bratseth bratseth merged commit 90ee764 into master Sep 3, 2024
3 of 4 checks passed
@bratseth bratseth deleted the theodorkl/fixIntelliJPubishAction branch September 3, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants