Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): update publish-cli.yml workflow to handle prefix in tag versions #32306

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

esolitos
Copy link
Contributor

@esolitos esolitos commented Aug 30, 2024

What

Modify the publish-cli.yml workflow to correctly extract the version from the git tag, removing the leading "v" prefix.

Why

This ensures the correct version is used for the published artifact, this caused the failure: https://github.com/vespa-engine/vespa/actions/runs/10629284465/job/29465892057

Error: You need to bump this formula manually since changing the version from 8.391.23 to v8.401.18 would be a downgrade.

Modify the publish-cli.yml workflow to correctly extract the version from the git tag, removing the leading "v" prefix. This ensures the
correct version is used for the published artifact.
@esolitos esolitos changed the title feat(ci): update publish-cli.yml to handle tag versions feat(ci): update publish-cli.yml workflow to handle prefix in tag versions Aug 30, 2024
@esolitos esolitos marked this pull request as ready for review August 30, 2024 12:36
@esolitos esolitos requested review from aressem and bjormel August 30, 2024 12:37
@esolitos esolitos self-assigned this Aug 30, 2024
@esolitos esolitos merged commit fbb9128 into master Sep 2, 2024
5 of 6 checks passed
@esolitos esolitos deleted the Virtual-branch branch September 2, 2024 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants