Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use filename in URL when storing downloaded file on disk #32293

Merged
merged 2 commits into from
Aug 30, 2024

Conversation

hmusum
Copy link
Member

@hmusum hmusum commented Aug 29, 2024

Rationale: To be able to decompress or transform a downloaded file based on file suffix

@toregge please review

@hmusum hmusum marked this pull request as ready for review August 29, 2024 06:39
@hmusum
Copy link
Member Author

hmusum commented Aug 29, 2024

@toregge please take a look again

Copy link
Member

@toregge toregge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@hmusum hmusum merged commit 3a87783 into master Aug 30, 2024
3 checks passed
@hmusum hmusum deleted the hmusum/keep-filename-when-downloading branch August 30, 2024 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants