Update cluster state publish time prior to updating convergence metrics #32237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use the time point of the last published state to infer if nodes should be counted as not converged, but this must be done for the publish time of the _new_ state, not the old state. Otherwise we risk over-counting.
hakonhall
approved these changes
Aug 23, 2024
hakonhall
deleted the
vekterli/update-publish-time-before-updating-metrics
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@hakonhall please review
We use the time point of the last published state to infer if nodes should be counted as not converged, but this must be done for the publish time of the new state, not the old state. Otherwise we risk over-counting.