Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix significance model resolver, better tests, handling of upper case in query words #32223

Merged
merged 6 commits into from
Aug 23, 2024

Conversation

glebashnik
Copy link
Contributor

@glebashnik glebashnik commented Aug 22, 2024

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

Implements the following logic for resolving models:

  • When language is explicitly tagged on query
    • Use language if available from the model registry, fail otherwise.
    • If “un” try both “un” and “en”.
  • When language is implicitly detected
    • Use language if available from the model registry. Fallback to “un” then “en”, fail if none are available.

Handling of query words containing upper case chars.

@glebashnik glebashnik requested review from geirst and toregge August 22, 2024 12:15
@glebashnik glebashnik changed the title Changed significance model resolver, added and refactored relevant tests Changed significance model resolver, improved tests, handling of upper case in query words Aug 22, 2024
@glebashnik glebashnik changed the title Changed significance model resolver, improved tests, handling of upper case in query words Fix significance model resolver, better tests, handling of upper case in query words Aug 22, 2024
geirst
geirst previously approved these changes Aug 22, 2024
Copy link
Member

@geirst geirst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Just one comment to improve readability of the tests.

@glebashnik glebashnik requested a review from geirst August 23, 2024 09:26
@geirst geirst merged commit d5825e8 into master Aug 23, 2024
3 checks passed
@geirst geirst deleted the glebashink/fix-significance-implicit-lang-resolver branch August 23, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants