Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate workflow to delete old Cloudsmith artifacts to GitHub Actions #32146

Merged
merged 14 commits into from
Aug 15, 2024

Conversation

glebashnik
Copy link
Contributor

@glebashnik glebashnik commented Aug 14, 2024

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

What

Adds a GitHub action workflow to delete old Cloudsmith artifacts.
The workflow is triggered either manually or on a daily schedule.

Why

Part of the process of retiring Screwdriver as CI/CD runner.

Additional Info

The corresponding Screwdriver pipeline is not removed since we don't have a dashboard for Github Actions yet.

See successful test run:
https://github.com/vespa-engine/vespa/actions/runs/10387039260/job/28759628746

@glebashnik glebashnik requested a review from esolitos August 14, 2024 12:02
@glebashnik
Copy link
Contributor Author

@bjormel Could you look at this test run and verify that it deleted what it should and no more:
https://github.com/vespa-engine/vespa/actions/runs/10387039260/job/28759628746

I haven't changed the core logic so should be ok but just in case.

Copy link
Contributor

@esolitos esolitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found an actual bug there!

.github/scripts/delete-old-cloudsmith-artifacts.sh Outdated Show resolved Hide resolved
@glebashnik glebashnik requested a review from esolitos August 14, 2024 13:31
@esolitos esolitos changed the title GitHub action workflow to delete old Cloudsmith artifacts Migrate workflow to delete old Cloudsmith artifacts to GitHub Actions Aug 15, 2024
@esolitos esolitos merged commit d6a74d4 into master Aug 15, 2024
3 checks passed
@esolitos esolitos deleted the glebashink/gh-action-delete-old-versions-in-archive branch August 15, 2024 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants