Skip to content

Commit

Permalink
Merge pull request #32163 from vespa-engine/revert-32159-remove-ckms-…
Browse files Browse the repository at this point in the history
…access-for-externalId_pt1

Revert "Don't populate externalId from ckms when building the config model" MERGEOK
  • Loading branch information
Arnstein Ressem authored Aug 17, 2024
2 parents 8354311 + 988aded commit fefe577
Showing 1 changed file with 5 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -25,15 +25,18 @@
import com.yahoo.config.provision.DataplaneToken;
import com.yahoo.config.provision.DockerImage;
import com.yahoo.config.provision.HostName;
import com.yahoo.config.provision.NodeResources;
import com.yahoo.config.provision.NodeResources.Architecture;
import com.yahoo.config.provision.SharedHosts;
import com.yahoo.config.provision.Zone;
import com.yahoo.container.jdisc.secretstore.SecretStore;
import com.yahoo.vespa.config.server.tenant.SecretStoreExternalIdRetriever;
import com.yahoo.vespa.flags.Dimension;
import com.yahoo.vespa.flags.FlagSource;
import com.yahoo.vespa.flags.Flags;
import com.yahoo.vespa.flags.PermanentFlags;
import com.yahoo.vespa.flags.StringFlag;
import com.yahoo.vespa.flags.UnboundFlag;

import java.io.File;
import java.net.URI;
Expand All @@ -43,6 +46,7 @@
import java.util.Optional;
import java.util.Set;
import java.util.concurrent.ExecutorService;
import java.util.function.Predicate;

import static com.yahoo.vespa.config.server.ConfigServerSpec.fromConfig;
import static com.yahoo.vespa.flags.Dimension.CLUSTER_TYPE;
Expand Down Expand Up @@ -450,7 +454,7 @@ public String athenzDnsSuffix() {

@Override
public List<TenantSecretStore> tenantSecretStores() {
return tenantSecretStores;
return SecretStoreExternalIdRetriever.populateExternalId(secretStore, applicationId.tenant(), zone.system(), tenantSecretStores);
}

@Override public String jvmGCOptions(Optional<ClusterSpec.Type> clusterType) {
Expand Down

0 comments on commit fefe577

Please sign in to comment.