Merge pull request #32189 from vespa-engine/vekterli/avoid-per-tick-m…

…etric-update-for-cc-failovers

Always set CC metric update cycle counter after update

clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/FleetController.java

@@ -374,12 +374,12 @@ private boolean maybePublishOldMetrics() {
                 metricUpdater.updateClusterStateMetrics(cluster, baselineState,
                         ResourceUsageStats.calculateFrom(cluster.getNodeInfos(), options.clusterFeedBlockLimit(), stateBundle.getFeedBlock()),
                         systemStateBroadcaster.getLastStateBroadcastTimePoint());
-                lastMetricUpdateCycleCount = cycleCount;
             } else {
                 // If we're not the master we don't have any authoritative information about
                 // how out of sync the cluster nodes are, so reset the metric.
                 metricUpdater.updateClusterBucketsOutOfSyncRatio(0);
             }
+            lastMetricUpdateCycleCount = cycleCount;
             return true;
         } else {
             return false;