Merge pull request #25123 from vespa-engine/mortent/setup-validator

Setup change validator
vespa-engine · Dec 6, 2022 · 3d4d764 · 3d4d764
2 parents 77cb75a + 0dcd228
commit 3d4d764
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/config-model/src/main/java/com/yahoo/vespa/model/application/validation/Validation.java b/config-model/src/main/java/com/yahoo/vespa/model/application/validation/Validation.java
@@ -10,6 +10,7 @@
 import com.yahoo.config.model.deploy.DeployState;
 import com.yahoo.config.provision.ClusterSpec;
 import com.yahoo.vespa.model.VespaModel;
+import com.yahoo.vespa.model.application.validation.change.CertificateRemovalChangeValidator;
 import com.yahoo.vespa.model.application.validation.change.ChangeValidator;
 import com.yahoo.vespa.model.application.validation.change.CloudAccountChangeValidator;
 import com.yahoo.vespa.model.application.validation.change.ClusterSizeReductionValidator;
@@ -121,7 +122,8 @@ private static List<ConfigChangeAction> validateChanges(VespaModel currentModel,
                 new ContainerRestartValidator(),
                 new NodeResourceChangeValidator(),
                 new RedundancyIncreaseValidator(),
-                new CloudAccountChangeValidator()
+                new CloudAccountChangeValidator(),
+                new CertificateRemovalChangeValidator()
         };
         List<ConfigChangeAction> actions = Arrays.stream(validators)
                                                  .flatMap(v -> v.validate(currentModel, nextModel, overrides, now).stream())

diff --git a/...om/yahoo/vespa/model/application/validation/change/CertificateRemovalChangeValidator.java b/...om/yahoo/vespa/model/application/validation/change/CertificateRemovalChangeValidator.java
@@ -17,7 +17,8 @@ public List<ConfigChangeAction> validate(VespaModel current, VespaModel next, Va
 
         current.getContainerClusters()
                 .forEach((clusterId, currentCluster) -> {
-                    validateClients(clusterId, currentCluster.getClients(), next.getContainerClusters().get(clusterId).getClients(), overrides, now);
+                    if(next.getContainerClusters().containsKey(clusterId))
+                        validateClients(clusterId, currentCluster.getClients(), next.getContainerClusters().get(clusterId).getClients(), overrides, now);
                 });
 
         return List.of();