Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix branch name #160

Merged
merged 2 commits into from
Oct 16, 2024
Merged

Fix branch name #160

merged 2 commits into from
Oct 16, 2024

Conversation

freva
Copy link
Member

@freva freva commented Oct 16, 2024

🤦

@freva freva requested a review from esolitos October 16, 2024 08:36
Copy link

@esolitos esolitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happens. :D
I did not catch it in #159

@@ -29,7 +29,7 @@ jobs:

- name: Store build artifact
uses: actions/upload-artifact@v4
if: github.ref == 'refs/heads/master'
if: github.ref == 'refs/heads/main'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about not hardcoding it?

Suggested change
if: github.ref == 'refs/heads/main'
if: github.ref_name == github.event.repository.default_branch

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better, thanks

@freva freva merged commit 41ff4a9 into main Oct 16, 2024
2 checks passed
@freva freva deleted the freva/gha branch October 16, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants