Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(colpalidemo) logging not print #1567

Merged
merged 12 commits into from
Nov 6, 2024
Merged

Conversation

thomasht86
Copy link
Contributor

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

  • Moved all print statements to logging. Removed some considered too verbose.
  • Added @lru_cache to the query embedding inference. Reduces load and time from ~0.3s->0.00s locally for cache hits.
  • Some minor cleaning.

@thomasht86 thomasht86 requested a review from andreer November 6, 2024 08:55
@andreer
Copy link
Member

andreer commented Nov 6, 2024

Great!

@thomasht86 thomasht86 merged commit 06817d2 into master Nov 6, 2024
3 checks passed
@thomasht86 thomasht86 deleted the thomasht86/logging-not-print branch November 6, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants