feat: add workflow to verify notebooks #1444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esolitos
force-pushed
the
Virtual-branch
branch
3 times, most recently
from
0aa8453 to
73d014a
Compare
aressem
approved these changes
Aug 20, 2024
glebashnik
requested changes
Aug 21, 2024
|
|
||
| - name: Install dependencies | ||
| run: | | ||
| pip install --upgrade -qqq pytest notebook nbconvert runnb pandas torch numpy scikit-learn |
There was a problem hiding this comment.
runnb is obscure package, better to use something better known and supported.
For pyvespa, we use papermill to run notebooks:
https://github.com/vespa-engine/pyvespa/blob/master/.github/workflows/notebooks-cloud.yml
There was a problem hiding this comment.
I don't know neither of the two, so my opinion is void. 😊
@glebashnik perhaps make it a ticket in JIRA so it can be evaulated?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Migrates the "Verify Notebooks" workflow to Github Actions.
Why
Part of the process of retiring Screwdriver as CI/CD runner.
Additional Info
N/A