Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type annotations in feed_data_point #987

Merged
merged 2 commits into from
Dec 11, 2024
Merged

Fix type annotations in feed_data_point #987

merged 2 commits into from
Dec 11, 2024

Conversation

kevinhu
Copy link
Contributor

@kevinhu kevinhu commented Dec 10, 2024

In feed_data_point, namespace, groupname, and semaphore should be annotated as Optional, as they are None by default.

@kkraune kkraune requested a review from thomasht86 December 10, 2024 09:54
@thomasht86
Copy link
Collaborator

Thanks - good catch! We need to use namespace: Optional[str] = None for now though, as we need to support Python 3.9 for a while longer.

thomasht86
thomasht86 requested changes Dec 10, 2024
View reviewed changes
vespa/application.py Outdated Show resolved Hide resolved
@kevinhu @thomasht86
Update vespa/application.py
32b3553 
Co-authored-by: Thomas Hjelde Thoresen <[email protected]>
@thomasht86 thomasht86 merged commit 9fe717e into vespa-engine:master Dec 11, 2024
31 of 46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasht86 thomasht86 thomasht86 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevinhu @thomasht86