Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) Query builder #985

Draft
wants to merge 42 commits into
base: master
Choose a base branch
from
Draft

(feat) Query builder #985

wants to merge 42 commits into from

Conversation

thomasht86
Copy link
Collaborator

@thomasht86 thomasht86 commented Dec 4, 2024

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

Consider this a first draft, and I can go through it tomorrow.

To discuss:

  • Should we allow for using kwargs for annotations - good for some, but many annotations are camelCase - does not good in python.
  • Rename Q and G- to what?

TODO:

  • Integration test for grouping

@thomasht86 thomasht86 requested a review from glebashnik December 4, 2024 14:31
@thomasht86
Copy link
Collaborator Author

thomasht86 commented Dec 5, 2024

TODOs after review:

  • Rename querybuilder/main.py. Check if there is a convention. If not, querybuilder.py
  • Queryfield -> QueryField
  • maybe use qb condition.
  • Describe how to build many queries programmatically (need to copy)
  • snake case for eg groupBy - dotProduct.
  • grouping to its own module

@thomasht86 thomasht86 force-pushed the thomasht86/qbuilder-poc branch from ac38825 to 58f19dd Compare December 5, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant