-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(ci) fix integrationtest vectorsearch #981
(ci) fix integrationtest vectorsearch #981
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure why you wouldn't reuse the cache and instead upload it as artifact?
What I would typically in this situation is one of those:
a. Have a "build" job which builds the application and stores an actions/upload-artifact. The dependant jobs only get the built artifact and don't run any install steps.
b. Don't have a build job and simply use actions/cache with restore-keys
that can fallback on a "older version" of the caches perfect match fails.
You seem to have mixed up caches and artifact and I don't see the benefit in this approach, unless I am missing something, that is. 😅
|
||
- name: Cache dependencies | ||
id: cache-python | ||
uses: actions/cache@v3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uses: actions/cache@v3 | |
uses: actions/cache@v4 |
- name: Upload Python environment | ||
uses: actions/upload-artifact@v3 | ||
with: | ||
name: python-environment | ||
path: ~/.cache/pip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand why you would use this instead of simply rely on actions/cache
for restoring as well?
- name: Download Python environment | ||
uses: actions/download-artifact@v3 | ||
with: | ||
name: python-environment | ||
path: ~/.cache/pip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use actions/cache + restore-key
instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, outdated version:
- name: Download Python environment | |
uses: actions/download-artifact@v3 | |
with: | |
name: python-environment | |
path: ~/.cache/pip | |
- name: Download Python environment | |
uses: actions/download-artifact@v4 | |
with: | |
name: python-environment | |
path: ~/.cache/pip |
Thanks! I will have another look at the |
9b081bc
to
d9fde8d
Compare
Ok, so it is 2 different things we ideally would want 2 cache.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏼
Amazing! Learned a new trick today as well :D Co-authored-by: Marlon (Esolitos) Saglia <[email protected]>
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.
This integration test has been unstable and slooow. 🐌
Some updates to improve stability and speed.
PR run here: https://github.com/vespa-engine/pyvespa/actions/runs/11970588855