(feat) support version-parameter in VespaCloud().deploy
#978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.
Why?
Make it possible to specify a
version-parameter when deploying todev/perf.How?
Make the
deploy()-method take aversion-parameter, that specifies desired Vespa version.Relevant code for how this is done with Vespa CLI: https://github.com/vespa-engine/vespa/blob/3f540e73fda47cbbf63dba9a9e980c3a839438ec/client/go/internal/vespa/deploy.go#L485
max_wait-param tofollow_deployment()(default to 1800s).Tests
It is difficult to maintain a test for this, as the available Vespa versions change continously.
I have run a manual integration test for this deployment, specifying
version="8.441.21", and verified that it is applied.