Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docsearch-feed): change enclave endpoint url for feeding to docsearch #942

Merged
merged 3 commits into from
Oct 1, 2024

Conversation

thomasht86
Copy link
Collaborator

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

Why

Feeding to docsearch fails due to deprecated endpoints.

What

This pull request includes updates to the URL-endpoints to feed to.

Please double-check that the correct endpoints are used.

@thomasht86 thomasht86 requested a review from esolitos October 1, 2024 08:41
Copy link
Contributor

@esolitos esolitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use those Yaml comments so we don't need to search for the endpoint in the future. 😊

_config.yml Show resolved Hide resolved
_config.yml Show resolved Hide resolved
_paragraphs_config.yml Show resolved Hide resolved
_suggestions_config.yml Show resolved Hide resolved
_suggestions_config.yml Show resolved Hide resolved
_paragraphs_config.yml Show resolved Hide resolved
@esolitos esolitos changed the title (docsearch-feed) change enclave endpoint url for feeding to docsearch fix(docsearch-feed): change enclave endpoint url for feeding to docsearch Oct 1, 2024
thomasht86 and others added 2 commits October 1, 2024 10:51
use yaml-comments to more easily verify correct endpoints

Co-authored-by: Marlon (Esolitos) Saglia <[email protected]>
@thomasht86 thomasht86 requested a review from esolitos October 1, 2024 08:52
@thomasht86 thomasht86 merged commit d6a997a into master Oct 1, 2024
28 of 30 checks passed
@thomasht86 thomasht86 deleted the thomasht86/update-docsearch-feed-endpoints branch October 1, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants