(feat) Support document expiry #936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glebashnik
reviewed
Sep 26, 2024
| # Create a ServicesConfiguration with document-expiry set to 1 day (timestamp > now() - 86400) | ||
| services_config = ServicesConfiguration( | ||
| application_name=application_name, | ||
| services_config=services( |
There was a problem hiding this comment.
Starting here linters complain that services, container, etc are not defined.
They can't see dynamically generated imports.
There was a problem hiding this comment.
Ref offline chat, I consider this as resolved for now, and taking a look on whether we can support this in the future.
When using linter-settings as defined inpyproject.toml these errors are ignored.
glebashnik
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.
Why
Ref. #854.
What
ServicesConfiguration-approach.validate_services-function (with tests).The intention is to add more examples to the
advanced-configuration.ipynbas we go.