(feat) Next iteration of all xml-support #929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glebashnik
approved these changes
Sep 23, 2024
| ) | ||
| orig_text = original.text or "" | ||
| gen_text = generated.text or "" | ||
| self.assertEqual(orig_text.strip(), gen_text.strip()) |
There was a problem hiding this comment.
The intention is for "" to equal None, why?
| @@ -64,6 +65,7 @@ def __iter__(self): | |||
|
|
|||
|
|
|||
| def attrmap(o): | |||
| o = dict(_global="global").get(o, o) | |||
There was a problem hiding this comment.
What is the purpose of this?
| tag.lower(), *_preproc(c, kw, attrmap=attrmap, valmap=valmap), void_=void_ | ||
| ) | ||
| # NB! fastcore.xml uses tag.lower() for tag names. This is not done here. | ||
| return VT(tag, *_preproc(c, kw, attrmap=attrmap, valmap=valmap), void_=void_) |
There was a problem hiding this comment.
What does preproc do?
A docstring for preproc would be nice.
| @@ -157,6 +164,8 @@ def _to_xml(elm, lvl, indent, do_escape): | |||
|
|
|||
| # Handle void (self-closing) tags | |||
| if elm.void_: | |||
| if isinstance(elm.void_, str): | |||
There was a problem hiding this comment.
For contxt, void_ is a bool?
Why check for str?
|
Thanks a lot for the input. Will address in following PR as discussed. |
thomasht86
deleted the
thomasht86/use-new-serviceconfiguration-in-package
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.
Why
For background and context, see #915
What
Added some more meat needed to ensure compatibility with old approach.
Still a good way to go, but getting closer.
Next iteration will have tests of compatibility with old approach, and more tests for new approach.