Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demonstrate that hamming MaxSim is a very good alternative to float based MaxSim #928

Merged
merged 4 commits into from
Sep 20, 2024

Conversation

jobergum
Copy link

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

@jobergum jobergum requested a review from thomasht86 September 19, 2024 13:00
@thomasht86
Copy link
Collaborator

Seems like a very attractive tradeoff! 💯
Would be nice if you could use a recent notebook as basis (without all the CLI-commands and auth-stuff that we now no longer need.) And Colab-badge. :)

@thomasht86
Copy link
Collaborator

See that CI fail due to missing PIL - pip install pillow

@jobergum
Copy link
Author

Will do! One issue here with having this in CD is that it takes 20 minutes to encode the corpus, but let us see first how long it takes, and then maybe run it once in a while or something.

@thomasht86
Copy link
Collaborator

Looks like we're not able to run this in CI without larger runners.
Crashes in Colab as well with the standard CPU runtime (works with T4 though).
I'll follow up on getting us access to larger runners, but we'll probably need to exclude it for now.

@jobergum
Copy link
Author

Yeah, as the model is 12GB and it encodes the images + overhead I do imagine we pass the runner memory limits. I would like to keep this notebook though so if you could disable it from test for now that would be great. Thanks!

Copy link
Collaborator

@thomasht86 thomasht86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@thomasht86 thomasht86 merged commit 2d380fe into master Sep 20, 2024
44 checks passed
@thomasht86 thomasht86 deleted the jobergum/add-benchmark-as-well branch September 20, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants