Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(docs) Make sure notebook is committed with output #919

Merged
merged 2 commits into from
Sep 17, 2024

Conversation

thomasht86
Copy link
Collaborator

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

If not, it is run (and will fail) on readthedocs, and give error output:
image

Source: https://nbsphinx.readthedocs.io/en/0.2.15/pre-executed.html

@thomasht86 thomasht86 requested a review from esolitos September 17, 2024 12:32
Copy link
Contributor

@esolitos esolitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼 Lots of changes, but seems to make sense. 😊

@thomasht86 thomasht86 merged commit 7b55d6b into master Sep 17, 2024
44 checks passed
@thomasht86 thomasht86 deleted the thomasht86/run-auth-notebook-output branch September 17, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants