Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rank to StructField #913

Merged
merged 2 commits into from
Sep 13, 2024

Conversation

maxice8
Copy link
Contributor

@maxice8 maxice8 commented Sep 12, 2024

fixes #912

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

@bratseth bratseth requested a review from thomasht86 September 13, 2024 07:28
@thomasht86
Copy link
Collaborator

Great, thanks!
Would like to have a corresponding unit test in test_package.py before we merge this.

@maxice8 maxice8 force-pushed the add-rank-to-struct-field branch from c6fa567 to e1b6c9c Compare September 13, 2024 15:42
@maxice8
Copy link
Contributor Author

maxice8 commented Sep 13, 2024

Added unittests, also git pull --rebase'd on top of the latest changes in master

Copy link
Collaborator

@thomasht86 thomasht86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@thomasht86 thomasht86 merged commit b16d657 into vespa-engine:master Sep 13, 2024
30 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for defining rank inside a struct-field
2 participants