-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new colpali example #908
Conversation
Input welcome on this, both language and code, also would be nice to see if we can get this into CI/CD |
Very cool! 🤩 Some comments:
!sudo apt-get install poppler-utils -y Should also move the note about poppler dependency there, and maybe link to other install options. . Takes 1.5*15=22.5 mins to run in Colab with A100 GPU. 🐌
Causes linting error in Colab (and older versions of eg. pylance Consider using https://pyvespa.readthedocs.io/en/latest/reference-api.html#vespa.application.Vespa.feed_async_iterable for feeding at least.
|
Great, thanks for this! Will iterate
This is super weird as it takes just 12-15 seconds per batch on my M1 with MPS |
Looks like the latest run encountered this hf issue |
Great. Ran successfully in 25mins - we can add it to CI. 👍 Consider less printout of b64-strings and embeddings (will force the reader to scroll a lot). |
It's a good overview diagram! Removed the larger output and also looks like cd passed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.