(ci) fix notebook environments in ci #907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esolitos
approved these changes
Sep 6, 2024
| notebook=$1 | ||
|
|
||
| # Now you can use the variable $notebook in your script | ||
| echo "The path to the notebook is \"$notebook\"" |
There was a problem hiding this comment.
Perhaps some (most?) of those echo should use the debug output option/prefix, so that we only show what is necessary on a normal run?
There was a problem hiding this comment.
Yes, didn't know about this. Thx!
Will fix the next times these files are touched!
Comment on lines
+75
to
+76
| echo "Running replace_pip_install_notebooks.sh" | ||
| sh .github/scripts/replace_pip_install_notebooks.sh ${{ matrix.notebook }} |
There was a problem hiding this comment.
The output of this could be wrapped in a log group. 😉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.
This PR solves #905 while still allowing us to keep using
!pip3 install package1 package2in the notebooks, so they they can be run directly from Colab.
To achieve this, I added a script that:
pyvespaandvespaclias they are already installed.additional_requirements.txtAlso, moved to using uv for package management for speed and ability to lock versions, in preparation for #824 . (For this workflow only for now, others to follow)