feat(pypi): update release workflow to use OIDC auth #900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Set to Draft as it requires adding the |
|
We should also do this for vespacli |
|
I will update also vespacli workflow. |
esolitos
force-pushed
the
update-pyvespa-version
branch
4 times, most recently
from
d62d535 to
3969a83
Compare
esolitos
force-pushed
the
update-pyvespa-version
branch
from
3969a83 to
fa2fe63
Compare
thomasht86
reviewed
Sep 2, 2024
thomasht86
reviewed
Sep 2, 2024
thomasht86
reviewed
Sep 2, 2024
Co-authored-by: Thomas Hjelde Thoresen <[email protected]>
Co-authored-by: Thomas Hjelde Thoresen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Update the "PyPi publishing" workflow to use OIDC authentication instead of personal-token.
Why
This removes the need of storing a secret with
PYPI_TOKEN_PYVESPAin it by using the Trusted publishing feature offered by PyPi.I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.