Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to new control-plane API #886

Merged
merged 20 commits into from
Aug 23, 2024
Merged

Switch to new control-plane API #886

merged 20 commits into from
Aug 23, 2024

Conversation

thomasht86
Copy link
Collaborator

@thomasht86 thomasht86 commented Aug 22, 2024

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

Took the opportunity to clean up a bit for a more consolidatet http-client usage.
Think this will also remove instability in integration tests (where http.connection was used previously)

  • Use new control plane-API
  • Hardcode dev region (similar to vespacli)
  • Switch to httpx-client for more unified usage
  • Add common user-agent header for all clients with version
  • Add integration tests for user-agent header

@thomasht86 thomasht86 closed this Aug 22, 2024
@thomasht86 thomasht86 reopened this Aug 22, 2024
@tokle tokle mentioned this pull request Aug 22, 2024
@thomasht86 thomasht86 marked this pull request as ready for review August 23, 2024 07:50
@thomasht86 thomasht86 requested a review from tokle August 23, 2024 07:50
@thomasht86
Copy link
Collaborator Author

This should be good now.
Spent some time making the tests pass, and think I was able to fix what caused sporadic integration test failures.
Now, all the http-connections used everywhere are subjected to the retry-policies, and use either requests or httpx

@thomasht86 thomasht86 merged commit abde66b into master Aug 23, 2024
45 checks passed
@thomasht86 thomasht86 deleted the thomasht86/switch-api branch August 23, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants