Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add significance documentation #3231

Merged
merged 18 commits into from
Oct 18, 2024
Merged

Conversation

MariusArhaug
Copy link
Contributor

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

@MariusArhaug MariusArhaug force-pushed the marius/significance-documentation branch from 734d55f to db50c8e Compare June 18, 2024 14:07
@MariusArhaug MariusArhaug self-assigned this Jun 18, 2024
@MariusArhaug MariusArhaug requested a review from bjorncs June 18, 2024 14:17
@kkraune
Copy link
Member

kkraune commented Jun 19, 2024

Great! not sure why we have two files in reference for this instead of just one

@bjorncs bjorncs requested a review from geirst June 19, 2024 07:33
Copy link
Member

@bjorncs bjorncs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll review the two new documents later (significance.html/significance-reference.html). Here's some feedback on the other files.

en/operations-selfhosted/vespa-cmdline-tools.html Outdated Show resolved Hide resolved
en/operations-selfhosted/vespa-cmdline-tools.html Outdated Show resolved Hide resolved
en/operations-selfhosted/vespa-cmdline-tools.html Outdated Show resolved Hide resolved
en/operations-selfhosted/vespa-cmdline-tools.html Outdated Show resolved Hide resolved
en/operations-selfhosted/vespa-cmdline-tools.html Outdated Show resolved Hide resolved
en/reference/schema-reference.html Outdated Show resolved Hide resolved
en/reference/services-search.html Outdated Show resolved Hide resolved
en/reference/services-search.html Outdated Show resolved Hide resolved
@MariusArhaug MariusArhaug force-pushed the marius/significance-documentation branch from e475c05 to 1a7e424 Compare June 19, 2024 13:29
en/reference/schema-reference.html Show resolved Hide resolved
en/reference/services-search.html Outdated Show resolved Hide resolved
@glebashnik glebashnik requested a review from geirst October 4, 2024 06:46
@glebashnik glebashnik force-pushed the marius/significance-documentation branch from 64ef5e8 to 130f6d7 Compare October 4, 2024 06:50
Copy link
Member

@geirst geirst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, some comments to look at.

Makefile Outdated Show resolved Hide resolved
en/reference/services-container.html Outdated Show resolved Hide resolved
en/reference/services-search.html Outdated Show resolved Hide resolved
en/reference/services-search.html Outdated Show resolved Hide resolved
en/reference/services-search.html Outdated Show resolved Hide resolved
Copy link
Member

@geirst geirst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@glebashnik glebashnik merged commit 1e07543 into master Oct 18, 2024
1 check passed
@glebashnik glebashnik deleted the marius/significance-documentation branch October 18, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants