New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get_impl_paths more exhaustive checks #1342

Open

tjhance wants to merge 1 commit into main from get-impl-paths-checks

Collaborator

tjhance commented Nov 13, 2024

get_impl_paths errors if it finds a trait bound that it doesn't know how to handle. Similar in spirit to #1341

This leaves a few open issues:

Handling Send/Sync correctly (get_impl_paths/recursion-checking does not handle Sync/Send inference #1335).
codegen_select_candidate returns Err sometimes, and we just ignore it. Was that intentional on our part? I would have expected to never see Err unless we weren't calling it properly.


          get_impl_paths checks

2541ca9

tjhance requested a review from Chris-Hawblitzel

November 13, 2024 05:29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet