Represent large sequence literals using the recently added ArrayLiteral support #1317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
couldn't fully resolve. In particular, the clean up of sequences now matches the process used by the seq_internal macro. Still debugging an issue with generic types.
Chris-Hawblitzel
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recently added ArrayLiteral support offers a path towards a more efficient encoding for sequence literals (compared to a push-based description), since it directly encodes the value at each index of the literal. This PR updates the
seq!macro to use a view of an equivalent array literal for sequence literals with more than one element. It also updates the interpreter to match this behavior in its specialized internal handling of sequences and arrays.