-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allowing some 3D tools to stretch to the dimensions of their container. #13
Conversation
✅ Deploy Preview for vertigis-web-incubator ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@edorableraf, those issues should be fixed now by my latest update. @scottander, please have a look at the changes when you have a sec. |
@eric-parsons Looks good. One styling nitpick that I missed from last time, but probably OK to merge with or without a fix. Font colour for the elevation profile layers is hard to read in dark mode: |
Looks good to me. |
I checked again and it looks fine now. Not sure what was the cause, but we're probably good to go.
|
Some minor styling changes to allow the shadow cast tool to stretch to its container's size. It was working previously only by accident because Esri's CSS had "width: 200" which is invalid. They changed it in 4.28 to "width: 200px" which made it much smaller and hard to use.
I also updated some packages to fix audit issues.