Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing some 3D tools to stretch to the dimensions of their container. #13

Merged
merged 2 commits into from
Dec 4, 2023

Conversation

eric-parsons
Copy link
Contributor

Some minor styling changes to allow the shadow cast tool to stretch to its container's size. It was working previously only by accident because Esri's CSS had "width: 200" which is invalid. They changed it in 4.28 to "width: 200px" which made it much smaller and hard to use.

I also updated some packages to fix audit issues.

Copy link

netlify bot commented Nov 30, 2023

Deploy Preview for vertigis-web-incubator ready!

Name Link
🔨 Latest commit 0545ef0
🔍 Latest deploy log https://app.netlify.com/sites/vertigis-web-incubator/deploys/656e042f5e53f4000878b968
😎 Deploy Preview https://deploy-preview-13--vertigis-web-incubator.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@edorableraf edorableraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the Slice component has some sizing issues:
image

Compared to the Line of Sight tool:
image

@eric-parsons
Copy link
Contributor Author

Looks like the Slice component has some sizing issues...

@edorableraf, those issues should be fixed now by my latest update. @scottander, please have a look at the changes when you have a sec.

@edorableraf
Copy link

@eric-parsons Looks good. One styling nitpick that I missed from last time, but probably OK to merge with or without a fix.

Font colour for the elevation profile layers is hard to read in dark mode:
image

@eric-parsons
Copy link
Contributor Author

Odd, it looks fine to me, both in preview and local:

image

Both in Brave and Firefox 🤷. It's either a caching issue or some strange OS issue.

@scottander
Copy link
Contributor

Looks like the Slice component has some sizing issues...

@edorableraf, those issues should be fixed now by my latest update. @scottander, please have a look at the changes when you have a sec.

Looks good to me.

@edorableraf
Copy link

I checked again and it looks fine now. Not sure what was the cause, but we're probably good to go.

Both in Brave and Firefox 🤷. It's either a caching issue or some strange OS issue.

@eric-parsons eric-parsons reopened this Dec 4, 2023
@eric-parsons eric-parsons merged commit 4678acc into main Dec 4, 2023
6 checks passed
@eric-parsons eric-parsons deleted the stretch-3d-tools branch December 4, 2023 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants