Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node: jest, add modulePathIgnorePatters option #1251

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

jmillan
Copy link
Member

@jmillan jmillan commented Dec 4, 2023

Indicate Jest not to look in worker/ nor rust/ for node modules.

Since flatbuffers is a npm module and also a subproject in worker folder, jest was complaining that there were two different modules for flatbuffers

Since flatbuffers is a subproject in worker folder there, jest was
complaining that there were two different modules for flatbuffers
@jmillan jmillan requested a review from ibc December 4, 2023 16:11
Copy link
Collaborator

@nazar-pc nazar-pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there include option? I'd prefer include option instead of exclude such that random things don't get included accidentally in the future.

@jmillan
Copy link
Member Author

jmillan commented Dec 4, 2023

Is there include option? I'd prefer include option instead of exclude such that random things don't get included accidentally in the future.

Unfortunately there is not https://jestjs.io/docs/configuration

@ibc
Copy link
Member

ibc commented Dec 4, 2023

Let's merge?

@jmillan jmillan merged commit bf57b8a into v3 Dec 4, 2023
36 checks passed
@jmillan jmillan deleted the jest-modulePathIgnorePatters branch December 4, 2023 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants