Fix UpdateIceServers method parameters format

src/Handler.cpp

@@ -98,19 +98,33 @@ namespace mediasoupclient
 		return this->pc->GetStats();
 	}
 
-	void Handler::UpdateIceServers(const json& iceServerUris)
+	void Handler::UpdateIceServers(const json& iceServersDescription)
 	{
 		MSC_TRACE();
 
 		auto configuration = this->pc->GetConfiguration();
 
 		configuration.servers.clear();
 
-		for (const auto& iceServerUri : iceServerUris)
+		for (const auto& iceServerDescription : iceServersDescription)
 		{
+			if (!iceServerDescription.contains("urls")) {
+				continue;
+			}
 			webrtc::PeerConnectionInterface::IceServer iceServer;
-
-			iceServer.uri = iceServerUri.get<std::string>();
+			if (iceServerDescription["urls"].is_string()) {
+				iceServer.urls = { iceServerDescription["urls"].get<std::string>() };
+			} else if (iceServerDescription["urls"].is_array()) {
+				iceServer.urls = iceServerDescription["urls"].get<std::vector<std::string>>();
+			} else {
+				continue;
+			}
+			if (iceServerDescription.contains("username")) {
+				iceServer.username = iceServerDescription["username"].get<std::string>();
+			}
+			if (iceServerDescription.contains("credential")) {
+				iceServer.password = iceServerDescription["credential"].get<std::string>();
+			}
 			configuration.servers.push_back(iceServer);
 		}
 

test/include/fakeParameters.hpp

@@ -11,5 +11,6 @@ json generateLocalDtlsParameters();
 json generateTransportRemoteParameters();
 std::string generateProducerRemoteId();
 json generateConsumerRemoteParameters(const std::string& codecMimeType);
+json generateIceServers();
 
 #endif

test/src/Handler.test.cpp

@@ -8,6 +8,7 @@
 
 static const json TransportRemoteParameters = generateTransportRemoteParameters();
 static const json RtpParametersByKind       = generateRtpParametersByKind();
+static const json IceServers                = generateIceServers();
 
 static mediasoupclient::PeerConnection::Options PeerConnectionOptions;
 
@@ -201,8 +202,13 @@ TEST_CASE("RecvHandler", "[Handler][RecvHandler]")
 		REQUIRE_NOTHROW(recvHandler.RestartIce(iceParameters));
 	}
 
-	SECTION("recvHandler.UpdateIceServers() succeeds")
+	SECTION("recvHandler.UpdateIceServers() succeeds with empty array")
 	{
 		REQUIRE_NOTHROW(recvHandler.UpdateIceServers(json::array()));
 	}
+
+	SECTION("recvHandler.UpdateIceServers() succeeds with non-empty array")
+	{
+		REQUIRE_NOTHROW(recvHandler.UpdateIceServers(IceServers));
+	}
 }

test/src/fakeParameters.cpp

@@ -477,3 +477,22 @@ json generateConsumerRemoteParameters(const std::string& codecMimeType)
 
 	return json::object();
 };
+
+json generateIceServers()
+{
+	auto json = R"(
+	[
+		{
+			"urls"       : [
+				"turn:t1.server.com",
+				"turn:t2.server.com"
+			],
+			"username"   : "fakeuser",
+			"credential" : "fakepass"
+		},
+		{
+			"urls" : "stun:s.server.com"
+		}
+	])"_json;
+	return json;
+};