Updated to work on Umbraco 10.x with Vendr 3.x

[niekvanderreest]

I've updated the reviews package for a private project, thought I'd contribute by creating an Umbraco 10 / Vendr 3 version.
I've tested the workings against the Vendr Demostore project installing from scratch.

One thing to keep in mind, the code assumes that when using .net6 you are also using umbraco 10, it's technically possible to run Umbraco 9 on .net6, but for this commit that would quite possibly cause dependency issues.
Any thoughts on this?

[bjarnef]

I haven't checked it the package with work on Vendr v3 or something currently if broken in the v2 package is installed on Vendr v3 and Umbraco 10.

However in case we need make these changes for Umbraco 10, maybe it should be a v3 of the package? Or maybe v3 should be .NET Core only to align with Vendr v3? What do you think @mattbrailsford ?

[mattbrailsford]

@bjarnef I've been releasing v3 specific versions of all our other packages such as Vendr Checkout which targets Umbraco v10+ only (so no .NET Framework support) so I'd probably say you might as well follow suite and just drop multi-targeting.

[mattbrailsford]

The changes look good, but yea, I'd drop multi-targeting so just remove all the #if statements and focus on .NET6+ / Umbraco v10. The only other thing I'd say drop is there are some SQL bits to do with SqlCE which isn't supported anymore so I'd get rid of those too.

Nice work though, and good to see a contribution for this 👍

[niekvanderreest]

I could rework to package to .net6 / vendr3 only, but my time the comming weeks is limited so might take some time before I can make another pull-request. @mattbrailsford good spot about the SQLCE code for .net6, I did notice and suspected it was legacy at that point.

[bjarnef]

@mattbrailsford should we create a v3/dev branch and can we target a v3 release for Umbraco 10 and 11 on .NET6 and .NET7?

The v3 release can remove the SQL CE specific code, .NET framework specific code and eventually specific SQLite support (I haven't checked much how much this differ from MSSQL).