Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport 470 0.8.x #473

Merged
merged 2 commits into from
Jun 9, 2021
Merged

Conversation

BenjamenMeyer
Copy link
Member

Thank you for submitting a pull request and becoming a contributor to the Vega Strike Core Engine.

Please answer the following:

Code Changes:

Issues:

Purpose:
Backport #470 to 0.8.x - a slight tweak of #463 to prevent overlaps with the in-game constant saved game name of New Game
Thanks @P-D-E for the work!

Test Details:

  • Test 1: Start game; select Load, select an invalid UTF-8 saved game; click load.
  • Test 2: Start game; start a new campaign; go to the concourse; click save/load; select an invalid UTF-8 saved game; click load

In both cases it should fail to load the game and present a message to the user.

@BenjamenMeyer BenjamenMeyer added this to the 0.8.x milestone Jun 8, 2021
@BenjamenMeyer BenjamenMeyer self-assigned this Jun 8, 2021
@BenjamenMeyer BenjamenMeyer merged commit a7ab45c into vegastrike:0.8.x Jun 9, 2021
Copy link
Contributor

@P-D-E P-D-E left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants