Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport 62 0.8.x #64

Merged
merged 6 commits into from
Jun 9, 2021
Merged

Backport 62 0.8.x #64

merged 6 commits into from
Jun 9, 2021

Conversation

BenjamenMeyer
Copy link
Member

Thank you for submitting a pull request and becoming a contributor to Vega Strike: Upon the Coldest Sea.

Please answer the following:

Code Changes:

Issues:

Purpose:
Backport #62 to 0.8.x
Thanks @P-D-E for the work!

Test Details:

  • Test 1: Start game; select Load, select an invalid UTF-8 saved game; click load.
  • Test 2: Start game; start a new campaign; go to the concourse; click save/load; select an invalid UTF-8 saved game; click load

In both cases it should fail to load the game and present a message to the user.

@BenjamenMeyer BenjamenMeyer added this to the 0.8.x milestone Jun 9, 2021
@BenjamenMeyer BenjamenMeyer self-assigned this Jun 9, 2021
@BenjamenMeyer BenjamenMeyer merged commit b6c5f99 into vegastrike:0.8.x Jun 9, 2021
P-D-E
P-D-E reviewed Jun 9, 2021
View reviewed changes
Copy link
Contributor

@P-D-E P-D-E left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@P-D-E P-D-E P-D-E left review comments

@Loki1950 Loki1950 Loki1950 approved these changes

@royfalk royfalk Awaiting requested review from royfalk

@evertvorster evertvorster Awaiting requested review from evertvorster

@stephengtuggy stephengtuggy Awaiting requested review from stephengtuggy

@nabaco nabaco Awaiting requested review from nabaco

Assignees

@BenjamenMeyer BenjamenMeyer

Labels
bug
Projects
None yet
Milestone
0.8.x
Development

Successfully merging this pull request may close these issues.
3 participants
@BenjamenMeyer @Loki1950 @P-D-E