-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clusternetwork.js refactoring #143
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…elpers.js; rename misc.js to svgPlots.js
Stale pull request message |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Currently PR may have some potential bugs due to some refactoring changes, more tests are on the way to weed out any of these potential bugs
Note: Current files that
clusternetwork.js
is being separated to (primarilyclustersOI.js
andtables.js
) are quite large right now, but plan is to modularize them in the near future as wellNote: Currently refactoring is happening at a function-wide / file-wide level, but refactoring to make the functions easier to understand and line-by-line refactoring / function documentation has not yet started. Quite a bit of effort likely needs to be devoted to this.
Breaking changes:
helpers.js
,misc.js
,timeDateUtil.js
,utils.js
intohelpers.js
; renamemisc.js
tosvgPlots.js
.clusternetwork.js
,clusterOI.js
, andtables.js
during the refactoring process of moving table drawing totables.js
(they now has aself
object passed in as the first argument, to share the variables ofclusternetwork.js
outside of itself)All / overall changes:
refactor
folder, which contains python script (hopefully more in the future) to assist with refactoring process, currently there exists just one that helps determine which functions can be easily refactored.clusternetwork.js
toclustersOfInterest.js
draw_node_table
) totables.js
self
-independent / de-coupled date helper functions fromclusternetwork.js
to newly-createdhelpers.js
Next steps for this PR: