Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added devcontainer.json and fixed Dockerfile #119

Merged
merged 12 commits into from
Nov 14, 2023
Merged

Added devcontainer.json and fixed Dockerfile #119

merged 12 commits into from
Nov 14, 2023

Conversation

niemasd
Copy link
Contributor

@niemasd niemasd commented Nov 11, 2023

With this devcontainer file, VS Code (and GitHub Codespaces) will be able to create the development environment automatically. I also fixed the yarn installation in the Dockerfile.

Copy link

vercel bot commented Nov 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hivtrace-viz ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 14, 2023 1:21am

Ubuntu had an old version of Node.js; needed to install it via nvm to get a modern version that hivtrace-viz supports
@niemasd
Copy link
Contributor Author

niemasd commented Nov 13, 2023

Actually, there are some more fixes that need to be made to the Dockerfile, so don't merge this specific PR yet. The tn93 and hivtrace ones should be good to go, though

@niemasd
Copy link
Contributor Author

niemasd commented Nov 13, 2023

I've ported the Dockerfile to use Oracle Linux instead of Ubuntu, and I'm now stuck at the same place as I was in Ubuntu:

#118 (comment)

@stevenweaver Thoughts?

@stevenweaver
Copy link
Member

I've updated the supported engines to 18 and 19 until underlying dependencies can be updated to support Node 20 and above in earnest.

@niemasd
Copy link
Contributor Author

niemasd commented Nov 14, 2023

@stevenweaver Great, thanks for the info! Switching to Node 18 worked perfectly. As of the following commit:

65db705

I'm able to build directly from the development environment with the following:

yarn
yarn develop # or yarn build

So this one should be good to go now! In GitHub Codespaces, I'm even able to load the deployed web app

@stevenweaver stevenweaver merged commit c1151a1 into veg:master Nov 14, 2023
2 checks passed
@stevenweaver
Copy link
Member

Many thanks @niemasd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants