-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(openobserve transform): Add OpenObserve as an officially supported sink #21531
base: master
Are you sure you want to change the base?
feat(openobserve transform): Add OpenObserve as an officially supported sink #21531
Conversation
@jszwedko could you help me review this? Is anything pending from my end? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, this PR doesn't require any code changes and it seems more like a user guide on how to configure an existing sink. It feels like https://github.com/vectordotdev/vector-demos might be the right place for this. Or it could live under a new Community
section in https://vector.dev/guides/
d9abffa
to
e9bd1fe
Compare
* implement SinkConfig for OpenObserveConfig * chore: add comments and update reference samples * chore: add openobserve to urls and services
.github/workflows/changes.yml
Outdated
@@ -104,6 +104,8 @@ on: | |||
value: ${{ jobs.int_tests.outputs.nginx }} | |||
opentelemetry: | |||
value: ${{ jobs.int_tests.outputs.opentelemetry }} | |||
openobserve: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
int_tests
is a GitHub job that detects if a branch contains changes to integration tests. Since you didn't added any integration tests dedicated to openobserve
you should revert all changes to .github/workflows/*
,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make sense
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 Left some nits. Since it affects the generated docs, you can run make generate-component-docs && make check-component-docs
to regren and validate.
Apply suggestions Co-authored-by: Pavlos Rontidis <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, this looks almost ready to merge 🚀
One comment here.
removing the trailing space
I have removed the space @pront |
Head branch was pushed to by a user without write access
Please add a changelog entry. You can find details on this document. |
Head branch was pushed to by a user without write access
added @pront |
Co-authored-by: Pavlos Rontidis <[email protected]>
Head branch was pushed to by a user without write access
Let's add a new "openobserve transform" scope somewhere here: https://github.com/vectordotdev/vector/blob/master/.github/workflows/semantic.yml#L182 |
Also, please see Line 89 in ac1e975
|
@pront I don't have the file in my PR, do you want me to open a new PR or just add the file in my existing PR? https://github.com/vectordotdev/vector/blob/master/.github/workflows/semantic.yml#L182 |
Feel free to ignore this, but you can sync your fork, More importantly, the changelog format is off and is blocking this PR from merging. |
This PR adds OpenObserve as an officially supported sink in Vector's documentation. OpenObserve utilizes an HTTP-based API for data ingestion, and this PR proposes updating the documentation with an example configuration for users to follow.
No new functionality is required, as the current HTTP sink already serves the purpose effectively. The primary goal is to improve user experience by offering clear guidance for setting up Vector with OpenObserve, ensuring confidence in its usage as a supported observability solution.
Why This Matters?
By officially documenting OpenObserve as a supported sink, we provide clear setup instructions for users, allowing them to confidently configure Vector for OpenObserve.
Closes: #21514