Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added interface for Advanced Compression API #25

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dciliske
Copy link

@dciliske dciliske commented May 8, 2020

So, like the issue that was raised last fall (#16), I need checksum support for frames. The Advanced Compression API adds this capability, so I've added an interface onto it.

@codecov
Copy link

codecov bot commented May 8, 2020

Codecov Report

Merging #25 into master will decrease coverage by 2.76%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #25      +/-   ##
==========================================
- Coverage   95.37%   92.60%   -2.77%     
==========================================
  Files           5        5              
  Lines         562      622      +60     
==========================================
+ Hits          536      576      +40     
- Misses         16       30      +14     
- Partials       10       16       +6     
Impacted Files Coverage Δ
gozstd.go 90.24% <66.66%> (-7.61%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3452344...5c0846f. Read the comment docs.

@kaxap
Copy link

kaxap commented Jun 18, 2020

any news on merging this?

@valyala
Copy link
Owner

valyala commented Jun 19, 2020

@kaxap , @dciliske , sorry for long delay - I had no time to review the PR :(

I'll try to allocate some time for reviewing it soon.

@gaby
Copy link

gaby commented Jan 19, 2023

@valyala Friendly ping 2.5 years later 😂 Any chance you can take a look at this PR?

@myxo
Copy link

myxo commented May 23, 2023

Hey, any chance this PR to be merged? Checksum support is highly desirable feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants