Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

angular 18 upgrade #1272

Merged
merged 4 commits into from
Jul 15, 2024
Merged

angular 18 upgrade #1272

merged 4 commits into from
Jul 15, 2024

Conversation

IgorKvasn
Copy link
Contributor

  • upgraded to angular 18
  • NX upgraded from 17 to 19 (this also upgraded angular to 18)

@IgorKvasn IgorKvasn mentioned this pull request Jun 4, 2024
@alex737876
Copy link

@valorkin can you do the review, merge and release?

@lexasq
Copy link
Contributor

lexasq commented Jul 2, 2024

@IgorKvasn today we've wrap up Angular 17 support properly, and unfortunatelly your PR now has conflicts, could you please work those out and come back? I'll be glad to help you on delivering those.

@IgorKvasn
Copy link
Contributor Author

I am on vacation right now, I'll have a look when I am back on 14th July

Signed-off-by: Igor Kvasnicka <[email protected]>

# Conflicts:
#	.eslintrc.json
#	libs/ng2-file-upload/package.json
#	package.json
@IgorKvasn
Copy link
Contributor Author

@lexasq conflicts resolved

@orgads orgads mentioned this pull request Jul 15, 2024
@lexasq
Copy link
Contributor

lexasq commented Jul 15, 2024

@IgorKvasn thanks a lot for your contributions, we'll going to release it soon!

@lexasq lexasq merged commit a0d7eb5 into valor-software:development Jul 15, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants