Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2 - Replace the configs with constants #18

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

joehu21
Copy link
Collaborator

@joehu21 joehu21 commented Dec 6, 2024

Removed configs that are not specified in the JSON RFC.

@joehu21 joehu21 self-assigned this Dec 6, 2024
@joehu21 joehu21 requested a review from roshkhatri December 6, 2024 15:43
Copy link
Member

@roshkhatri roshkhatri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joehu21 joehu21 merged commit 3daf183 into valkey-io:unstable Dec 10, 2024
3 checks passed
@joehu21 joehu21 deleted the issue2c branch December 10, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants