Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy SERVER_TEST compiler flag from cmake. #1530

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

karthyuom
Copy link
Contributor

This PR is to cleanup the SERVER_TEST compiler flag from cmake compile definitions, as it is no longer required in the new unit test framework (see #428).

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.88%. Comparing base (0a89571) to head (d13adf3).
Report is 4 commits behind head on unstable.

Additional details and impacted files
@@             Coverage Diff              @@
##           unstable    #1530      +/-   ##
============================================
+ Coverage     70.87%   70.88%   +0.01%     
============================================
  Files           120      120              
  Lines         64959    64959              
============================================
+ Hits          46041    46048       +7     
+ Misses        18918    18911       -7     

see 11 files with indirect coverage changes

@enjoy-binbin enjoy-binbin merged commit 80c3540 into valkey-io:unstable Jan 9, 2025
49 of 50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants