refactor: use argp library for parsing command line options and arguments
#1525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uments This commit changes the command line parsing code of `valkey-benchmark` to use the `argp` library (https://www.gnu.org/software/libc/manual/html_node/Argp.html), which is included in libc. This makes the options and arguments parsing more structured and easy to extend. Signed-off-by: Ricardo Dias <[email protected]>
rjd15372
force-pushed
the
refactor-benchmark-cli
branch
from
a2b73d7 to
ac868bd
Compare
|
|
Shoot. I should have checked that before implementing this. I guess that's why the parsing was being done manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the command line parsing code of
valkey-benchmarkto use theargplibrary (https://www.gnu.org/software/libc/manual/html_node/Argp.html), which is included in libc.This makes the options and arguments parsing more structured and easy to extend.