[feature] sentinel use info sentinel command to run faster

[kukey]

In sentinel cluster, sentinels will send info command to collect valkey-server state;
but in large cluster, the info command response is heavy and slow, so we need some
simple info response for sentinel.

changes in this pr:

valkey-server:

• add info-simple-for-sentinel flag, to distinguish the valkey-server is support simple info;
• info command add sentinel subcommand, to cover sentinel used info

sentinel:

• sentinelValkeyInstance struct add info_simple flag;
• sentinelSendPeriodicCommands will check info_simple to send diff comamnd;
• reconnect valkey instacne, reset info_simple flag;
• handle info response from server to parse info_simple flag

performence test:

• info comamnd:
  valkey-benchmark -q -n 1000000 info
  info: 65841.45 requests per second, p50=0.703 msec
• info sentinel:
  valkey-benchmark -q -n 1000000 info sentinel
  info sentinel: 236910.67 requests per second, p50=0.111 msec

[codecov]

Codecov Report

Attention: Patch coverage is 67.50000% with 13 lines in your changes missing coverage. Please review.

Project coverage is 70.83%. Comparing base (b3b4bdc) to head (2837997).
Report is 2 commits behind head on unstable.

Files with missing lines	Patch %	Lines
src/sentinel.c	0.00%	7 Missing ⚠️
src/server.c	81.81%	6 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##           unstable    #1511      +/-   ##
============================================
- Coverage     70.83%   70.83%   -0.01%     
============================================
  Files           120      120              
  Lines         64911    64930      +19     
============================================
+ Hits          45982    45993      +11     
- Misses        18929    18937       +8     

Files with missing lines	Coverage Δ
src/config.c	78.33% <ø> (ø)
src/server.h	100.00% <ø> (ø)
src/server.c	87.33% <81.81%> (-0.14%)	⬇️
src/sentinel.c	0.00% <0.00%> (ø)

... and 10 files with indirect coverage changes

[hwware]

Is this config only for sentinel? If yes, I think it should be moved to sentinel.c, we have some specific config parameters for sentinel node.

[kukey]

@hwware yes，this config only for sentinel, but it`s mean valkey has a certain ability that sentinel could send diff command to collect instance stats. It`s a server capability. I think it can`t remove to sentinel.c. 2025年1月8日 03:47，Wen Hui ***@***.***> 写道： @hwware commented on this pull request.

________________________________ In src/config.c<#1511 (comment)>:

@@ -3373,6 +3373,9 @@ standardConfig static_configs[] = {

createSpecialConfig("replicaof", "slaveof", IMMUTABLE_CONFIG | MULTI_ARG_CONFIG, setConfigReplicaOfOption, getConfigReplicaOfOption, rewriteConfigReplicaOfOption, NULL), createSpecialConfig("latency-tracking-info-percentiles", NULL, MODIFIABLE_CONFIG | MULTI_ARG_CONFIG, setConfigLatencyTrackingInfoPercentilesOutputOption, getConfigLatencyTrackingInfoPercentilesOutputOption, rewriteConfigLatencyTrackingInfoPercentilesOutputOption, NULL), + /* Capabalities */ + createBoolConfig("info-simple-for-sentinel", NULL, IMMUTABLE_CONFIG, server.info_simple_for_sentinel, 1, NULL, NULL), Is this config only for sentinel? If yes, I think it should be moved to sentinel.c, we have some specific config parameters for sentinel node. — Reply to this email directly, view it on GitHub<#1511 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAB25FPD44A4SCEG7OFGMHD2JQVOPAVCNFSM6AAAAABUVPCVFGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKMZVGIZTKNJWGM>. You are receiving this because you authored the thread.Message ID: ***@***.***>