Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove releasetools folder #1496

Merged
merged 1 commit into from
Jan 2, 2025
Merged

Conversation

hwware
Copy link
Member

@hwware hwware commented Dec 30, 2024

The release tool utils\releasetools\ does not work anymore in Valkey, in this PR, we remove it.

Signed-off-by: hwware <[email protected]>
@hwware hwware force-pushed the remove-release-tools branch from 278d738 to c567af9 Compare December 30, 2024 17:15
@hwware hwware requested a review from roshkhatri December 30, 2024 17:25
Copy link

codecov bot commented Dec 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.71%. Comparing base (8b40341) to head (c567af9).
Report is 8 commits behind head on unstable.

Additional details and impacted files
@@             Coverage Diff              @@
##           unstable    #1496      +/-   ##
============================================
- Coverage     70.84%   70.71%   -0.14%     
============================================
  Files           119      119              
  Lines         64860    64861       +1     
============================================
- Hits          45953    45867      -86     
- Misses        18907    18994      +87     

see 13 files with indirect coverage changes

Copy link
Member

@roshkhatri roshkhatri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Yes we do not use this anymore

@hwware hwware merged commit ede4add into valkey-io:unstable Jan 2, 2025
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants