Java: Support most RESP3 types #804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Yury-Fridlyand <[email protected]>
Add support for RESP3 types (Part 1)
shachlanAmazon
approved these changes
Jan 17, 2024
shachlanAmazon
approved these changes
Jan 22, 2024
| @ValueSource(strings = {"hello", "cat", "dog"}) | ||
| public void redisValueToJavaValue_BulkString(String input) { | ||
| public void redisValueToJavaValue_BulkString() { | ||
| String input = "😀\n💎\n🗿"; |
There was a problem hiding this comment.
impeccable choice of emojis!
Yury-Fridlyand
added a commit
to Bit-Quill/valkey-glide
that referenced
this pull request
Jan 24, 2024
* Implement support for receiving Redis arrays * Add support for simpler RESP3 types * Add some unit tests for FFI * Add more tests and support for VerbatimStrings * Fix and test Map and Set types * Add TODO about using conditional compilation flag in a separate test Gradle task * Remove dependency on ordered_float * Fix spotless errors * Attempt to fix CI test failures by updating Gradle task to build Rust * Update build.gradle to try to fix CI tests again * Change assertTrue nilValue == null to assertNull Co-authored-by: Yury-Fridlyand <[email protected]> * Remove init and teardown * Parameterize tests * Update client/build.gradle * Remove TODO about using primitive integers * Add tests for casting Redis Ints to Java Integers * Move FFI testing code to a separate module * Update build.gradle to use a new task to run FfiTests * Apply spotless changes * Address PR comments on FFI tests * Run spotless with new whitespace changes --------- Co-authored-by: Yury-Fridlyand <[email protected]>
SanHalacogluImproving
pushed a commit
to Bit-Quill/valkey-glide
that referenced
this pull request
Jan 25, 2024
* Implement support for receiving Redis arrays * Add support for simpler RESP3 types * Add some unit tests for FFI * Add more tests and support for VerbatimStrings * Fix and test Map and Set types * Add TODO about using conditional compilation flag in a separate test Gradle task * Remove dependency on ordered_float * Fix spotless errors * Attempt to fix CI test failures by updating Gradle task to build Rust * Update build.gradle to try to fix CI tests again * Change assertTrue nilValue == null to assertNull Co-authored-by: Yury-Fridlyand <[email protected]> * Remove init and teardown * Parameterize tests * Update client/build.gradle * Remove TODO about using primitive integers * Add tests for casting Redis Ints to Java Integers * Move FFI testing code to a separate module * Update build.gradle to use a new task to run FfiTests * Apply spotless changes * Address PR comments on FFI tests * Run spotless with new whitespace changes --------- Co-authored-by: Yury-Fridlyand <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes:
This PR adds support for RESP3 types, excluding Attribute, Push, and BigNumber, since these are not supported by other wrappers yet and are trickier to implement.
Each type has a Java unit test to check if Redis Values are marshaled into Java values correctly.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.