Fix transactions not converting values internally. #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 26, 2023
shachlanAmazon
force-pushed
the
use-transaction
branch
from
798deb5 to
ccb82dc
Compare
barshaul
reviewed
Dec 27, 2023
glide-core/tests/test_client.rs
Outdated
| assert!(result.is_err()); | ||
| let err = result.unwrap_err(); | ||
| assert!(err.is_timeout(), "{err}"); | ||
| }); | ||
| } | ||
|
|
||
| #[rstest] | ||
| // #[timeout(SHORT_CLUSTER_TEST_TIMEOUT)] |
barshaul
approved these changes
Dec 27, 2023
Renamed `send_pipeline` to `send_transaction`, in order to separate it from a function that can handle non-transactional pipeline. Added logic that checks the structure of the response, and converts all values to their expected form.
shachlanAmazon
force-pushed
the
use-transaction
branch
from
ccb82dc to
ca93803
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renamed
send_pipelinetosend_transaction, in order to separate it from a function that can handle non-transactional pipeline. Added logic that checks the structure of the response, and converts all values to their expected form.Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.