Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more type conversions and commands. #726

Closed

Conversation

shachlanAmazon
Copy link
Contributor

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Collaborator

@barshaul barshaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this PR should include changing config get return type in the wrappers (or move it to a different PR).
Also, please add Set type to TResult in python and the equivalent generic result type in node

@shachlanAmazon
Copy link
Contributor Author

and the equivalent generic result type in node

See node's lib.rs - set currently returns array.

closing and moving into #731, since this requires a lot of python work.

@shachlanAmazon shachlanAmazon deleted the more-conversions branch December 31, 2023 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants