Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return Okay on succesful client creation. #711

Merged
merged 1 commit into from
Dec 24, 2023

Conversation

shachlanAmazon
Copy link
Contributor

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@barshaul
Copy link
Collaborator

@shachlanAmazon
You should fix this function in redis_client.py:

    async def _set_connection_configurations(self) -> None:
        conn_request = self._get_protobuf_conn_request()
        response_future: asyncio.Future = self._get_future(0)
        await self._write_or_buffer_request(conn_request)
        await response_future
        if response_future.result() is not None:
            raise ClosingError(response_future.result())

@shachlanAmazon shachlanAmazon force-pushed the ok branch 2 times, most recently from a489909 to dd33fc4 Compare December 21, 2023 14:24
@shachlanAmazon shachlanAmazon requested a review from a team as a code owner December 24, 2023 16:16
@shachlanAmazon shachlanAmazon merged commit 708a2bb into valkey-io:main Dec 24, 2023
18 checks passed
@shachlanAmazon shachlanAmazon deleted the ok branch December 24, 2023 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants